Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: <webview> focus / blur events don't work with contextIsolation enabled #29004

Merged
merged 1 commit into from
May 5, 2021
Merged

fix: <webview> focus / blur events don't work with contextIsolation enabled #29004

merged 1 commit into from
May 5, 2021

Conversation

miniak
Copy link
Contributor

@miniak miniak commented May 4, 2021 •
edited

Description of Change

electron/lib/renderer/web-view/web-view-impl.ts

Line 165 in 961b74b

const hasFocus = document.activeElement === this.webviewNode;
is not equal when contextIsolation is enabled

Checklist

Release Notes

Notes: Fixed <webview> focus / blur events not working with contextIsolation enabled.

@miniak miniak added semver/patch backwards-compatible bug fixes target/10-x-y labels May 4, 2021
@miniak miniak self-assigned this May 4, 2021
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 4, 2021
@miniak miniak force-pushed the miniak/webview-focus-ctx-isolation branch 2 times, most recently from e01b1df to 0dbd4d0 Compare May 4, 2021 23:48
@nornagon
Copy link
Member

nornagon commented May 4, 2021

test?

@miniak miniak force-pushed the miniak/webview-focus-ctx-isolation branch from 0dbd4d0 to 1cf2aa5 Compare May 5, 2021 00:40
@miniak
Copy link
Contributor Author

miniak commented May 5, 2021

@nornagon test added

@MarshallOfSound MarshallOfSound merged commit 476e908 into master May 5, 2021
@release-clerk
Copy link

release-clerk bot commented May 5, 2021

Release Notes Persisted

Fixed &lt;webview&gt; focus / blur events not working with contextIsolation enabled.

@MarshallOfSound MarshallOfSound deleted the miniak/webview-focus-ctx-isolation branch May 5, 2021 18:31
@trop
Copy link
Contributor

trop bot commented May 5, 2021

I was unable to backport this PR to "10-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented May 5, 2021

I was unable to backport this PR to "11-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/11-x-y label May 5, 2021
@trop trop bot mentioned this pull request May 5, 2021
Merged
@trop trop bot mentioned this pull request May 5, 2021
Merged
@trop
Copy link
Contributor

trop bot commented May 5, 2021

I have automatically backported this PR to "12-x-y", please check out #29024

@trop
Copy link
Contributor

trop bot commented May 5, 2021

I have automatically backported this PR to "13-x-y", please check out #29025

miniak added a commit that referenced this pull request May 5, 2021
@miniak
fix: <webview> focus / blur events don't work with contextIsolation e…
c1a5874 
…nabled (#29004)
@miniak miniak mentioned this pull request May 5, 2021
Merged
@trop
Copy link
Contributor

trop bot commented May 5, 2021

@miniak has manually backported this PR to "10-x-y", please check out #29026

miniak added a commit that referenced this pull request May 5, 2021
@miniak
fix: <webview> focus / blur events don't work with contextIsolation e…
887942b 
…nabled (#29004)
@miniak miniak mentioned this pull request May 5, 2021
Merged
@trop
Copy link
Contributor

trop bot commented May 5, 2021

@miniak has manually backported this PR to "11-x-y", please check out #29027

zcbenz pushed a commit that referenced this pull request May 6, 2021
@miniak
fix: <webview> focus / blur events don't work with contextIsolation e…
ecb162c 
…nabled (#29004) (#29027)
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 6, 2021
miniak added a commit that referenced this pull request May 6, 2021
@miniak
fix: <webview> focus / blur events don't work with contextIsolation e…
d990be3 
…nabled (#29004)
@trop trop bot removed the in-flight/10-x-y label May 7, 2021
zcbenz pushed a commit that referenced this pull request May 7, 2021
@miniak
fix: <webview> focus / blur events don't work with contextIsolation e…
29d8cf5 
…nabled (#29004) (#29026)
@trop trop bot added the merged/10-x-y label May 7, 2021
@Mario-Kart-Felix Mario-Kart-Felix mentioned this pull request May 17, 2021
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees

@miniak miniak

Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miniak @nornagon @codebytere @MarshallOfSound